API Harmonization #15
Conversation
Signed-off-by: Tiago Nascimento <tiago.nascimento@spruceid.com>
- Fixed test cases parsing to follow json unmarshalling number to float64 - Update submodule to api harmonization tests - URL and Domain validation - Remove spaces from matching groups in URI - Modify return type on `Verify` - Add domain, nonce, timestamp optional parameters to `Verify`
Signed-off-by: Tiago Nascimento <tiago.nascimento@spruceid.com>
siwe.go
Outdated
| return validateURI, nil | ||
| } | ||
|
|
||
| func InitMessage(domain, address, uri, version string, options map[string]interface{}) (*Message, error) { |
There was a problem hiding this comment.
just wondering why issued at, nonce and expiration are in the options map since those are mandatory and should be always present?
There was a problem hiding this comment.
do we need to provide the version since it is always 1?
There was a problem hiding this comment.
can we provide inline doc for public / exported functions?
There was a problem hiding this comment.
+1 on @awoie suggestion on not making version string a required parameter here.
| } | ||
| validateResources[i] = *validateResource | ||
| } | ||
| result["resources"] = validateResources | ||
| } | ||
|
|
||
| return result, nil |
There was a problem hiding this comment.
can we provide inline doc for public / exported functions -> ParseMessage(...): Message?
| @@ -221,7 +303,7 @@ func (m *Message) VerifyEIP191(signature string) (*ecdsa.PublicKey, error) { | |||
| return pkey, nil | |||
| } | |||
|
|
|||
| func (m *Message) Verify(signature string, nonce *string, timestamp *time.Time) (*ecdsa.PublicKey, error) { | |||
| func (m *Message) Verify(signature string, domain *string, nonce *string, timestamp *time.Time) (*ecdsa.PublicKey, error) { | |||
There was a problem hiding this comment.
can we provide inline doc for public / exported functions?
| @@ -281,7 +332,7 @@ func parsingPositive(t *testing.T, cases map[string]interface{}) { | |||
| } | |||
| } | |||
|
|
|||
| func validationNegative(t *testing.T, cases map[string]interface{}) { | |||
| func verificationNegative(t *testing.T, cases map[string]interface{}) { | |||
There was a problem hiding this comment.
more like a general question and not related for this PR but would it make sense to move those tests to the global test vectors as well at some point?
Signed-off-by: Tiago Nascimento <tiago.nascimento@spruceid.com>
Signed-off-by: Tiago Nascimento <tiago.nascimento@spruceid.com>
Signed-off-by: Tiago Nascimento <tiago.nascimento@spruceid.com>
This PR as discussed internally tries to harmonize all siwe libraries to a similar behavior across all different languages.