Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add did:webkey method and SSH public key functions #178

Merged
merged 4 commits into from Jun 21, 2021
Merged

Add did:webkey method and SSH public key functions #178

merged 4 commits into from Jun 21, 2021

Conversation

clehner
Copy link
Contributor

@clehner clehner commented Apr 15, 2021 •
edited

Implement did:webkey proposed in #176.

  • Initial setup
  • Parse SSH public keys
  • Hash SSH public key and/or JWK to get fingerprint
  • Connect to SSH agent to request signature

Future work

@clehner clehner mentioned this pull request Apr 26, 2021
Closed
@clehner clehner changed the title WIP: did:webkey method Add did:webkey method May 20, 2021
@clehner clehner marked this pull request as ready for review May 20, 2021 01:21
@clehner clehner mentioned this pull request May 20, 2021
Merged
11 tasks
This was referenced Jun 1, 2021
Open
Open
Open
Open
@wyc wyc requested review from sbihel and chunningham June 10, 2021 20:50
sbihel
sbihel requested changes Jun 14, 2021
View reviewed changes
Copy link
Member

@sbihel sbihel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

Cargo.toml Outdated Show resolved Hide resolved
src/ssh.rs Show resolved Hide resolved
src/ssh.rs Outdated Show resolved Hide resolved
src/jwk.rs Outdated Show resolved Hide resolved
src/jwk.rs Outdated Show resolved Hide resolved
@clehner clehner changed the title Add did:webkey method Add did:webkey method and SSH public key functions Jun 16, 2021
@wyc
Copy link
Contributor

wyc commented Jun 17, 2021

Would love to see the conflicts resolved to get this merged.

chunningham
chunningham approved these changes Jun 21, 2021
View reviewed changes
Copy link
Member

@chunningham chunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work! also wondered why ssh fns would go in ssi but am satisfied with your explanation to @sbihel

@clehner
Copy link
Contributor Author

clehner commented Jun 21, 2021

Rebased and squashed related commits

@wyc wyc merged commit bf21287 into main Jun 21, 2021
@wyc wyc deleted the feat/did-webkey branch June 21, 2021 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbihel sbihel sbihel approved these changes

@chunningham chunningham chunningham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@clehner @wyc @sbihel @chunningham