Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ethereum Personal Signature 2021 #212

Merged
merged 1 commit into from Jun 28, 2021
Merged

Add Ethereum Personal Signature 2021 #212

merged 1 commit into from Jun 28, 2021

Conversation

clehner
Copy link
Contributor

@clehner clehner commented Jun 14, 2021

A signature suite based on signing strings prefixed in Ethereum Personal Message (personal_sign) format.

Like Ethereum EIP712 Signature 2021 and Eip712Method2021, but for when you have personal_sign but not eth_signTypedData. Uses URDNA2015 and N-Quads (like TezosSignature2021).

The string for signing is the canonicalized N-Quads of the proof options, followed by a newline, followed by canonicalized N-Quads of the linked data proof (e.g. verifiable credential). This string is prefixed and hashed according to "Ethereum Personal Message" signing.

Example signing request for EthereumPersonalSignature2021 showing signing string.

ethereum-personal-signature-signature-request-metamask

  • Initial implementation
  • Fix public key recovery
  • Add test vector

@clehner clehner marked this pull request as ready for review June 15, 2021 21:12
src/ldp.rs Show resolved Hide resolved
src/ldp.rs Show resolved Hide resolved
src/ldp.rs Outdated Show resolved Hide resolved
@wyc
Copy link
Contributor

wyc commented Jun 24, 2021

Please rebase and fix conflicts. Thanks!

@clehner
Copy link
Contributor Author

clehner commented Jun 25, 2021

Rebased and squashed. Edit: fixing conflicts with EthereumPersonalSignature2021. Edit: fixed, rebased and squashed again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants