Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add struct for CAIP-2 chain id #283

Merged
merged 1 commit into from
Sep 10, 2021
Merged

Add struct for CAIP-2 chain id #283

merged 1 commit into from
Sep 10, 2021

Conversation

clehner
Copy link
Contributor

@clehner clehner commented Sep 9, 2021

Add a module for CAIP-2 (chain id) with a ChainId struct, similar to the module for CAIP-10 (account id) with a BlockchainAccountId struct.
Update the BlockchainAccountId struct to use the ChainId struct internally.

This should make it easier to operate on blockchain account and chain ids.

@clehner clehner marked this pull request as draft September 9, 2021 16:28
@clehner clehner marked this pull request as ready for review September 9, 2021 17:37
@clehner clehner requested a review from sbihel September 9, 2021 20:39
@clehner
Copy link
Contributor Author

clehner commented Sep 10, 2021

Rebasing and merging

@clehner clehner merged commit 9f9f874 into main Sep 10, 2021
@clehner clehner deleted the feat/caip-2 branch September 10, 2021 15:58
@clehner clehner mentioned this pull request Sep 10, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants