Support public key hex values in did:ethr #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbihel
approved these changes
Sep 13, 2021
clehner
force-pushed
the
feat/ethr-pkhex
branch
from
f94158a
to
a4d6684
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support resolving
did:ethrDIDs using thepublic-key-hexform (66 hex char public key).As noted by @vdods in spruceid/didkit#207, the
did:ethrimplementation here before only supported the account address (ethereum-address) form.The DID used as a test vector is from a DID Test Suite test vector from the Universal Resolver: https://github.com/w3c/did-test-suite/blob/e12272e/packages/did-core-test-server/suites/implementations/universal-resolver-did-ethr.json