Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Credentials Module #150

Merged
merged 4 commits into from
Jul 27, 2023

Conversation

Juliano1612
Copy link
Member

Description

This adds the Credentials Modules, which allows developers to fetch credentials issued on SpruceKit Credential Issuer.
This module requires Storage Module, so you must enable both to make it work.

const ssx = SSX({
  modules: {
    storage: true,
    credentials: true
  }
})

await ssx.signIn();

const { data } = ssx.credentials.list();

Type

  • New feature (non-breaking change which adds functionality)

Diligence Checklist

  • I added a changelog with all changes I made in this PR
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have made corresponding changes to the documentation (if required)
  • Any dependent changes have been merged and published in downstream modules

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 64.63% and project coverage change: -0.26% ⚠️

Comparison is base (cab5a7e) 79.70% compared to head (0a973a7) 79.44%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #150      +/-   ##
==========================================
- Coverage   79.70%   79.44%   -0.26%     
==========================================
  Files          34       35       +1     
  Lines        4365     4446      +81     
  Branches      252      254       +2     
==========================================
+ Hits         3479     3532      +53     
- Misses        886      914      +28     
Files Changed Coverage Δ
...kages/ssx-sdk/src/modules/Storage/KeplerStorage.ts 25.52% <11.11%> (-0.35%) ⬇️
packages/ssx-sdk/src/ssx.ts 80.18% <52.17%> (-2.90%) ⬇️
packages/ssx-sdk/src/modules/Credentials.ts 79.59% <79.59%> (ø)
packages/ssx-sdk/src/modules/index.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

packages/ssx-sdk/src/ssx.ts Show resolved Hide resolved
packages/ssx-sdk/src/modules/Credentials.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@skgbafa skgbafa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid PR

@Juliano1612 Juliano1612 merged commit c942c3c into spruceid:main Jul 27, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants