SUPESC-282 Fixed handling of response while empty through allowing null value #6
Conversation
|
These changes on transfer level are not BC |
…adyen-integration-guide' into bugfix/supesc-282-issues-in-eco-adyen-integration-guide
|
You removed the CI part that you initially wanted to fix |
Fixed composer.json errors
| class: PhpStan\DynamicType\ZedFactoryDynamicTypeExtension | ||
| tags: | ||
| - phpstan.broker.dynamicMethodReturnTypeExtension | ||
| - '#.+Generated\\Shared\\Transfer.+.#' |
There was a problem hiding this comment.
it is very common pattern we should avoid those. use more specifics patterns here.
There was a problem hiding this comment.
If there are no transfers generated this is fine for now
But I would advise to generate the transfers as per standalone testing guide
This will be better long term, but can also be a follow up PR.
| <property name="returnUrl" type="string" /> | ||
| <property name="amount" type="AdyenApiAmount"/> | ||
| <property name="merchantAccount" type="string"/> | ||
| <property name="paymentMethod" type="array" singular="paymentMethodItem"/> |
There was a problem hiding this comment.
- This is a BC break.
- By default the generated method will have a name
addPaymentMethod()and now it will be changed toaddPaymentMethodItem, all code that could have been written on the client side will crash.
There was a problem hiding this comment.
Possible solutions are to roll back changes or singular has to be equal to name property in order to warranty the BC promise.
There was a problem hiding this comment.
Please see #6 (review)
There was a problem hiding this comment.
Yeah, it looks like one, but apparently the singular is already exactly this by other module
So this seems OK to release now in this verbose state.
Good that we make it more visible now :)
spryker-release-bot
deleted the
bugfix/supesc-282-issues-in-eco-adyen-integration-guide
branch
Developer(s): @michbeck
Ticket: https://spryker.atlassian.net/browse/SUPESC-282
Release Group: https://release.spryker.com/release-groups/view/3346
merge: squash
Release Table
Module AdyenApi
Change log
Fixes