Release 1.0.0 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MISC initial composer.json
…optivo into feature/eco-1681/dev-optivo # Conflicts: # src/SprykerEco/Zed/Optivo/Business/OptivoFacade.php # src/SprykerEco/Zed/Optivo/Business/OptivoFacadeInterface.php # src/SprykerEco/Zed/Optivo/Communication/Plugin/Oms/Command/OptivoNewOrderPlugin.php
Episerver (Optivo) Initial Release
|
Fix comments from #2 before release |
…ctoring ECO-2469: fixed TechLead comments
gechetspr
reviewed
Mar 25, 2019
| */ | ||
| interface EpiserverConstants | ||
| { | ||
| public const CONFIGURATION_DEFAULT_MAILING_ID_LIST = 'EPISERVER:CONFIGURATION_DEFAULT_MAILING_ID_LIST'; |
There was a problem hiding this comment.
This should be marked with @api tag, because this type of constants are part of the public api
gechetspr
approved these changes
Mar 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developer(s): @SergeBabich @vhrychenko @Ruslan05
Ticket: https://spryker.atlassian.net/browse/ECO-1681
Please confirm
Documentation
Release Table
Release Notes
Added Episerver mail service functionality
Module Episerver
Change log
Initial Release
Added Episerver mail service functionality to send Customer, Order and Newsletter emails through a third-party service