Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK-2546: Fixed incorect method use from the collection interface. #137

Merged
merged 19 commits into from
Aug 23, 2023
Merged

SDK-2546: Fixed incorect method use from the collection interface. #137

merged 19 commits into from
Aug 23, 2023

Conversation

vol4onok
Copy link
Contributor

@vol4onok vol4onok commented Aug 19, 2023 •
edited
Loading

@codecov
Copy link

codecov bot commented Aug 19, 2023 •
edited
Loading

Codecov Report

Merging #137 (eb2ab6c) into master (2828f1d) will increase coverage by 3.31%.
The diff coverage is 89.90%.

@@             Coverage Diff              @@
##             master     #137      +/-   ##
============================================
+ Coverage     81.70%   85.00%   +3.31%     
- Complexity     1585     1595      +10     
============================================
  Files           139      139              
  Lines          4212     4228      +16     
============================================
+ Hits           3441     3594     +153     
+ Misses          771      634     -137
Files Changed Coverage Δ
src/Builder/Finder/ClassNodeFinder.php 57.14% <0.00%> (-19.05%) ⬇️
...nifestStrategy/ConfigureModuleManifestStrategy.php 92.73% <ø> (+1.50%) ⬆️
...trategy/UnwireGlueRelationshipManifestStrategy.php 59.38% <ø> (+38.79%) ⬆️
.../ManifestStrategy/UnwireWidgetManifestStrategy.php 54.17% <ø> (+31.09%) ⬆️
...tStrategy/WireGlueRelationshipManifestStrategy.php 59.38% <ø> (+38.79%) ⬆️
...rc/ManifestStrategy/WireWidgetManifestStrategy.php 45.45% <ø> (+24.62%) ⬆️
src/Builder/ClassLoader/ClassLoader.php 94.23% <92.59%> (+0.68%) ⬆️
...der/Visitor/AddPluginToPluginCollectionVisitor.php 97.53% <95.65%> (-0.77%) ⬇️
src/Builder/ClassBuilderFacade.php 92.00% <100.00%> (+24.00%) ⬆️
src/Builder/ClassGenerator/ClassGenerator.php 82.54% <100.00%> (+17.46%) ⬆️
... and 9 more

... and 5 files with indirect coverage changes

@pavelmaksimov25 pavelmaksimov25 changed the title Feature/sdk 2546 use incorect method from the collection interface SDK-2546 Use incorect method from the collection interface. Aug 22, 2023
@pavelmaksimov25 pavelmaksimov25 changed the title SDK-2546 Use incorect method from the collection interface. SDK-2546 Fixed incorect method use from the collection interface. Aug 22, 2023
pavelmaksimov25
pavelmaksimov25 suggested changes Aug 22, 2023
View reviewed changes
integrator.lock Outdated Show resolved Hide resolved
src/Builder/ComposerClassLoader/ComposerClassLoader.php Outdated Show resolved Hide resolved
src/Builder/Finder/ClassNodeFinder.php Show resolved Hide resolved
src/Builder/Visitor/AddPluginToPluginCollectionVisitor.php Show resolved Hide resolved
src/Builder/Visitor/AddPluginToPluginCollectionVisitor.php Outdated Show resolved Hide resolved
@vol4onok vol4onok changed the title SDK-2546 Fixed incorect method use from the collection interface. SDK-2546: Fixed incorect method use from the collection interface. Aug 22, 2023
@pavelmaksimov25 pavelmaksimov25 merged commit ec8b68b into master Aug 23, 2023
11 checks passed
@pavelmaksimov25 pavelmaksimov25 deleted the feature/sdk-2546-use-incorect-method-from-the-collection-interface branch August 23, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelmaksimov25 pavelmaksimov25 pavelmaksimov25 approved these changes

@DmytroKlymanSpryker DmytroKlymanSpryker DmytroKlymanSpryker approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vol4onok @pavelmaksimov25 @DmytroKlymanSpryker