Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new security requirements for TLS server certificates in iOS 13 and macOS 10.15. #92

Closed
tienbuide opened this issue Apr 15, 2020 · 3 comments

Comments

@tienbuide
Copy link

Apple has new security requirements for TLS server certificates in iOS 13 and macOS 10.15[1].
the result is following error (see screenshot below):

NET::ERR_CERT_INVALID

an inconvenient bypass this error (in Chrome) is to type thisisunsafe.

a more convenient solution would be to provide a valid server cert with invalid cert authority, which provides a link to access the page (see screenshot below)

[1] https://support.apple.com/en-us/HT210176

NET ERR_CERT_AUTHORITY_INVALID

NET ERR_CERT_INVALID

@alexanderM91
Copy link
Collaborator

alexanderM91 commented Jun 3, 2020

Hi, @tienbuide,
thank you for your contribution.
This should have been fixed here - https://github.com/spryker/docker-sdk/releases/tag/1.14.1

@tienbuide
Copy link
Author

hey @alexanderM91,
thanks for not letting me be a contributor by accepting my pull request and copying (almost) everything of it instead

¯\_(ツ)_/¯

@Incognito
Copy link
Contributor

Hey @tienbuide we have a complex process and we're working on figuring out our contributor guidelines right now. Our team has a specific process we follow for merging work to master which @alexanderM91 followed correctly. I don't think anyone here wanted to remove credit from your contribution but I'll escalate this internally so we can adjust our process guidelines and we can do better in the future.

For additional transparency: 800+ of our public repos are split from just a few monorepos. This usually means directly merging external contributions is a bit harder for us, so typically our developer assigned to the task will manually port it into our monorepo to let the release process publish it again. However, in this case, docker-sdk is not part of a monorepo and it would have been possible to accept your commit. Because this repo is not very typical for our workflow it was just not expected to be the way to get the job done.

Sorry about that, and we're working on improving the contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants