chore(picking): refactor picking component names #759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dev-fulfillment ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dev-oryx-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dev-composable-storefront ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
1 flaky test on run #10104 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| ... > should show a global error if an error occurs while cart editing |
Output
Screenshots
Video
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
Passing run #2399 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
|
It's not a breaking change as long as this module is not release yet. |
…ore/hrz-89742-refactor-picking-component-names
Sinucid
suggested changes
Sep 14, 2023
apps/fulfillment-e2e/src/support/page_fragments/picking-in-progress-modal.fragment.ts
Outdated
Show resolved
Hide resolved
libs/domain/picking/customer-note-modal/customer-note-modal.def.ts
Outdated
Show resolved
Hide resolved
Sinucid
suggested changes
Sep 18, 2023
There was a problem hiding this comment.
Additional changes, that I would like to ask you to make:
- PickingListMixinInterface implements interface from picking-lists component ( PickingListComponentProperties ), that is ridiculous. Move it, please, to the src/models
- login and picker components have default exports, that looks strange and unreasonable. Drop them, please, and use exported classes directly
Sinucid
previously approved these changes
Sep 18, 2023
aleespryker
force-pushed
the
chore/hrz-89742-refactor-picking-component-names
branch
from
06f33fb
to
a8d58f8
Compare
tolerants
requested changes
Sep 20, 2023
Sinucid
previously approved these changes
Sep 20, 2023
…tps://github.com/spryker/oryx into chore/hrz-89742-refactor-picking-component-names
Sinucid
suggested changes
Sep 20, 2023
tolerants
approved these changes
Sep 22, 2023
Sinucid
approved these changes
Sep 22, 2023
aleespryker
deleted the
chore/hrz-89742-refactor-picking-component-names
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picking components are now labelled differently.
eg,
<oryx-customer-note></oryx-customer-note>is now<oryx-picking-customer-note></oryx-picking-customer-note>according to our components naming conventions.closes: HRZ-89742