feat(fulfillment): notify user about push notification support and permission #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added browser's permissions check and support for push notification API that is required by offline mode. - created compositions for picking and customer note pages - fulfillment app integrated with notification center - fixed word break behavior of notification component's text content with long words - `refresh data` button in FA profile menu was renamed to `sync data`, and the button became disabled in offline mode to prevent unnecessary requests errors - NetworkState service was added to platform offline package to observe browser's network state - `getList` method was added to picking list service to get picking list by id - `PickingListContextFallback` was added to provide fallback picking list context by `pickingListId` route param closes: [HRZ-90430](https://spryker.atlassian.net/browse/HRZ-90430)
closes: HRZ-90484
✅ Deploy Preview for dev-oryx-components canceled.
|
✅ Deploy Preview for dev-fulfillment canceled.
|
✅ Deploy Preview for dev-composable-storefront ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
2 flaky tests on run #11281 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Search suite > Products sorting > should apply all sorting options |
Test Replay
Screenshots
Video
|
|
locales.cy.ts • 1 flaky test • sf-regression
| Test | Artifacts | |
|---|---|---|
| Locales suite > should save the locale selection when navigating on site |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #914 ↗︎
supproduction
requested changes
Nov 17, 2023
libs/platform/offline/src/services/network-state-default.service.ts
Outdated
Show resolved
Hide resolved
supproduction
requested changes
Nov 17, 2023
supproduction
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added browser's permissions and supports for push notification API that is required by offline mode.
with long words
refresh databutton in FA profile menu was renamed tosync data,and the button became disabled in offline mode to prevent unnecessary
requests errors
browser's network state
getListmethod was added to picking list service to get picking listby id
PickingListContextFallbackwas added to provide fallback pickinglist context by
pickingListIdroute paramcloses: HRZ-90415