Skip to content

Commit

Permalink
Merge pull request #382 from spsanderson/development
Browse files Browse the repository at this point in the history
Fixes #379
  • Loading branch information
spsanderson committed Dec 11, 2023
2 parents 260e260 + 867e2f7 commit 269a255
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
7 changes: 6 additions & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
# TidyDensity (development version)

## Breaking Changes
None
1. Fix #350 - This has caused the function `tidy_multi_single_dist()` to be modified
in that it now requires the user to pass the parameter of `.return_tibbl` with either
TRUE or FALSE as it was introduced into the `tidy_` distribution functions which now
use `data.table` under the hood to generate data.

## New Features
1. Fix #360 - Add function `tidy_triangular()`
Expand All @@ -15,6 +18,8 @@ None
which speeds these up by over 100x
2. Fix #350 - Update all `tidy_` distribution functions to generate data using `data.table`
this in many instances has resulted in a speed up of 30% or more.
3. Fix #379 - Replace the use of `dplyr::cur_data()` as it was deprectated in
dplyr in favor of using `dplyr::pick()`

# TidyDensity 1.2.6

Expand Down
3 changes: 2 additions & 1 deletion R/combine-multi-single-dist-tbl.R
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,8 @@ tidy_multi_single_dist <- function(.tidy_dist = NULL,

# Run call on the grouped df ----
dff <- param_grid %>%
dplyr::mutate(results = purrr::pmap(dplyr::cur_data(), match.fun(td)))
dplyr::mutate(results = purrr::pmap(dplyr::pick(dplyr::everything()), match.fun(td)))
#dplyr::mutate(results = purrr::pmap(dplyr::cur_data(), match.fun(td)))

# Get the attributes to be used later on ----
atb <- dff$results[[1]] %>% attributes()
Expand Down

0 comments on commit 269a255

Please sign in to comment.