Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix downloader #102

Closed
wants to merge 5 commits into from
Closed

Fix downloader #102

wants to merge 5 commits into from

Conversation

fvoges
Copy link

@fvoges fvoges commented Nov 19, 2014

This patch changes two things in install.pp

  • Switches the download tool from wget to curl to allow the use of
    the 'file://' scheme for the download URL (wget doesn't support file://)
  • Checks $::gitlab::puppet_manage_packages before declaring
    Package['curl']. This follows the behaviour of the other dependencies
    and Puppet best practices.

Federico Voges added 2 commits November 19, 2014 13:51
 - Switches the download tool from wget to curl to allow the use of
   the 'file://' scheme for the download URL (wget doesn't support file://)
 - Checks $::gitlab::puppet_manage_packages before declaring
   Package['curl']. This follows the behaviour of the other dependencies
   and Puppet best practices.
@spuder
Copy link
Owner

spuder commented Nov 19, 2014

Thanks for the merge request. I've noticed that the gitlab download page recommends using wget for the ubuntu packages, but curl for the centos packages.

Before this gets merged, I'd like to consider the following:

@fvoges
Copy link
Author

fvoges commented Nov 19, 2014

curl has options to set timeouts:

--connect-timeout <seconds>
    Maximum time in seconds that you allow the connection to the server to take.  This only limits the
    connection phase, once curl has connected this option is of no more use. See also the -m/--max-time option.
-m/--max-time <seconds>
    Maximum time in seconds that you allow the whole operation to take.  This is useful for preventing
    your batch  jobs  from  hanging for hours due to slow networks or links going down.  See also 
    the --connect-timeout option.

}
# Use wget to download gitlab

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not nanliu/staging?

@fvoges
Copy link
Author

fvoges commented Jan 2, 2015

The latest commits moved the package declaration to packages.pp as requested

@spuder spuder added this to the 2.4.x milestone Mar 9, 2015
@spuder spuder mentioned this pull request Mar 9, 2015
@igalic
Copy link
Contributor

igalic commented Apr 30, 2015

this has been sitting around for long enough that gitlab has made it obsolete by now offering apt/yum repositories.

@fvoges fvoges closed this May 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants