-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix downloader #102
Fix downloader #102
Conversation
- Switches the download tool from wget to curl to allow the use of the 'file://' scheme for the download URL (wget doesn't support file://) - Checks $::gitlab::puppet_manage_packages before declaring Package['curl']. This follows the behaviour of the other dependencies and Puppet best practices.
Thanks for the merge request. I've noticed that the gitlab download page recommends using wget for the ubuntu packages, but curl for the centos packages. Before this gets merged, I'd like to consider the following:
|
curl has options to set timeouts:
|
} | ||
# Use wget to download gitlab |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not nanliu/staging
?
The latest commits moved the package declaration to packages.pp as requested |
this has been sitting around for long enough that gitlab has made it obsolete by now offering apt/yum repositories. |
This patch changes two things in install.pp
the 'file://' scheme for the download URL (wget doesn't support file://)
Package['curl']. This follows the behaviour of the other dependencies
and Puppet best practices.