Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto-reload support to logstash configuration file #30

Merged
merged 2 commits into from Apr 6, 2016

Conversation

davidt99
Copy link

@davidt99 davidt99 commented Apr 6, 2016

No description provided.

@spujadas
Copy link
Owner

spujadas commented Apr 6, 2016

Good idea. Rather than having it in the args variable, could you move the option to the LS_OPTS variable?

@davidt99
Copy link
Author

davidt99 commented Apr 6, 2016

Done

@spujadas spujadas merged commit e72d961 into spujadas:master Apr 6, 2016
@spujadas
Copy link
Owner

spujadas commented Apr 6, 2016

Cheers.

@spujadas
Copy link
Owner

spujadas commented Apr 7, 2016

Sorry, had to revert this one due to Logstash crashing (as reported in #32) when config files contain conditionals (which is the case in the default image), see elastic/logstash#5014, elastic/logstash#4968 — my mistake, didn't test the patch properly.

As this is supposed to have been fixed in Logstash 2.3.1, which was released a couple of hours ago, I'll upgrade the image and attempt to re-add the --auto-reload option (and test it properly!).

@davidt99
Copy link
Author

davidt99 commented Apr 7, 2016

I don't experiencing this issue, but I in the other hand, I don't use filebeat and the reason why I need to change the config.
I will try to look in to that in sunday.

spujadas added a commit that referenced this pull request Apr 7, 2016
also readded auto-reload option for Logstash (see #30 for background information)
@spujadas
Copy link
Owner

spujadas commented Apr 7, 2016

OK, that would explain.
Anyway, I've just upgraded Logstash in the image, tested it with --auto-reload, and it's running properly, so you can get the latest image (the build is in progress on Docker Hub, should be ready in a few minutes) and it should work fine.
If you do run some tests on Sunday and run into problems with this updated image, let me know.

spujadas added a commit that referenced this pull request May 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants