Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup fails on python 3.5 #32

Closed
wants to merge 6 commits into from
Closed

Conversation

soloman1124
Copy link

Hi, I am unable to install it with python 3.5. it throws:

  Cloning https://github.com/SimpleHQ/PyQS.git (to master) to /tmp/pip-build-rvimtnln/pyqs
    Complete output from command python setup.py egg_info:
    running egg_info
    creating pip-egg-info/pyqs.egg-info
    writing pip-egg-info/pyqs.egg-info/PKG-INFO
    writing top-level names to pip-egg-info/pyqs.egg-info/top_level.txt
    writing dependency_links to pip-egg-info/pyqs.egg-info/dependency_links.txt
    writing requirements to pip-egg-info/pyqs.egg-info/requires.txt
    writing entry points to pip-egg-info/pyqs.egg-info/entry_points.txt
    writing manifest file 'pip-egg-info/pyqs.egg-info/SOURCES.txt'
    warning: manifest_maker: standard file '-c' not found

    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-build-rvimtnln/pyqs/setup.py", line 68, in <module>
        include_package_data=True,
      File "/usr/local/lib/python3.5/distutils/core.py", line 148, in setup
        dist.run_commands()
      File "/usr/local/lib/python3.5/distutils/dist.py", line 955, in run_commands
        self.run_command(cmd)
      File "/usr/local/lib/python3.5/distutils/dist.py", line 974, in run_command
        cmd_obj.run()
      File "/usr/local/lib/python3.5/site-packages/setuptools/command/egg_info.py", line 180, in run
        self.find_sources()
      File "/usr/local/lib/python3.5/site-packages/setuptools/command/egg_info.py", line 207, in find_sources
        mm.run()
      File "/usr/local/lib/python3.5/site-packages/setuptools/command/egg_info.py", line 291, in run
        self.add_defaults()
      File "/usr/local/lib/python3.5/site-packages/setuptools/command/egg_info.py", line 320, in add_defaults
        sdist.add_defaults(self)
      File "/usr/local/lib/python3.5/site-packages/setuptools/command/sdist.py", line 117, in add_defaults
        if self.distribution.has_pure_modules():
      File "/usr/local/lib/python3.5/distutils/dist.py", line 980, in has_pure_modules
        return len(self.packages or self.py_modules or []) > 0
    TypeError: object of type 'filter' has no len()

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 88f7b1c on SimpleHQ:python3.5 into d368f49 on spulec:master.

@spulec
Copy link
Owner

spulec commented Jun 17, 2016

Looks like Travis is failing on some imports due to py2/py3 inconsistency. We should probably add six and use that

@soloman1124
Copy link
Author

hi, @spulec we actually need few more additional things to make pyqs work on our project. I will actually just use my fork for that and close this PR.

so, besides make it working for python 3, I actually added the following:

  • be able to specify log configuration (because we need json logging format for our service)
  • able to specify PYQS_ENDPOINT_URL so that we can work locally with (https://github.com/vsouza/docker-SQS-local)
  • also use lru_cache to cache queue fetch on the decorator.

I am not sure if you want include any of these in the road map. but they are quite useful to us :)

@soloman1124 soloman1124 changed the title PR - setup fails on python 3.5 setup fails on python 3.5 Jun 20, 2016
@Blue-Dog-Archolite
Copy link

Any movement on this?

@spulec
Copy link
Owner

spulec commented Nov 4, 2017

This should be fixed with #41

@spulec spulec closed this Nov 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants