Ignore nose plugins to prevent test timing issues #236
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I upgraded from
freezegun
0.3.9 to 0.3.10, my CircleCI builds started taking longer. Upon further inspection, the tests were being distributed very strangely across the available containers. This was because thexunit
output about how long each test took to run was very wrong; one test that took a few ms to run was marked as taking 25494780 seconds. After realizing that value was being consistently reported every time, I thought time might be stopped, and sure enough, downgrading fixed my builds (as did this proposed change).I'm not sure what is different between 0.3.9 and 0.3.10 that breaks the timing component of the built-in
xunit
plugin, so I can't offer a more targeted fix. Please consider this change to addnose.plugins
to the ignore list.