Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore nose plugins to prevent test timing issues #236

Merged
merged 1 commit into from Apr 19, 2018

Conversation

hwkns
Copy link
Contributor

@hwkns hwkns commented Apr 18, 2018

When I upgraded from freezegun 0.3.9 to 0.3.10, my CircleCI builds started taking longer. Upon further inspection, the tests were being distributed very strangely across the available containers. This was because the xunit output about how long each test took to run was very wrong; one test that took a few ms to run was marked as taking 25494780 seconds. After realizing that value was being consistently reported every time, I thought time might be stopped, and sure enough, downgrading fixed my builds (as did this proposed change).

I'm not sure what is different between 0.3.9 and 0.3.10 that breaks the timing component of the built-in xunit plugin, so I can't offer a more targeted fix. Please consider this change to add nose.plugins to the ignore list.

@coveralls
Copy link

coveralls commented Apr 18, 2018

Coverage Status

Coverage increased (+0.01%) to 94.17% when pulling afc9ddc on hwkns:ignore-nose-plugins into 5d02625 on spulec:master.

@spulec spulec merged commit 43624d3 into spulec:master Apr 19, 2018
@spulec
Copy link
Owner

spulec commented Apr 19, 2018

Sounds good, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants