Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cleanup] Fix CI by removing maya for pypy3 test and some various cleanup #363

Merged
merged 1 commit into from Jul 22, 2020

Conversation

Djailla
Copy link

@Djailla Djailla commented Jul 17, 2020

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.852% when pulling 1cd2924 on Djailla:cleanup into 9b730f0 on spulec:master.

@coveralls
Copy link

coveralls commented Jul 17, 2020

Coverage Status

Coverage remained the same at 91.852% when pulling c70f2b2 on Djailla:cleanup into 9b730f0 on spulec:master.

@boxed
Copy link
Contributor

boxed commented Jul 17, 2020

I don't think we should drop pypy...

@Djailla
Copy link
Author

Djailla commented Jul 17, 2020

It fails for testing, not to deploy.

About CI, any though migrating to github actions ?

@boxed
Copy link
Contributor

boxed commented Jul 18, 2020

This commit does remove pypy from setup.py and I don't trust support if we can't get it to work in CI. This isn't good imo.

@boxed
Copy link
Contributor

boxed commented Jul 18, 2020

As for github actions: I don't really care. I have more experience with Travis.

@Djailla Djailla force-pushed the cleanup branch 6 times, most recently from 71229f3 to 074b3a7 Compare July 21, 2020 21:23
@Djailla Djailla changed the title [cleanup] Fix CI by removing pypy3 test and some various cleanup [cleanup] Fix CI by removing maya for pypy3 test and some various cleanup Jul 21, 2020
@Djailla
Copy link
Author

Djailla commented Jul 21, 2020

Hello @boxed I did some changes to the PR if you want to check

@boxed boxed merged commit b46da78 into spulec:master Jul 22, 2020
@boxed
Copy link
Contributor

boxed commented Jul 22, 2020

Thanks for the fixes!

@Djailla Djailla deleted the cleanup branch July 22, 2020 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants