Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename excluded package "Queue" to match its python 3 name #527

Merged
merged 2 commits into from
Jan 14, 2024

Conversation

yonil
Copy link
Contributor

@yonil yonil commented Jan 1, 2024

On python 3 Queue was renamed to queue. As a result it seems this is no longer excluding the queue package.

@yonil yonil changed the title rename package to match its python 3 name rename excluded package "Queue" to match its python 3 name Jan 1, 2024
@bblommers
Copy link
Collaborator

One of our tests is failing with this change:

https://github.com/spulec/freezegun/actions/runs/7378273067/job/20138768211?pr=527

@yonil
Copy link
Contributor Author

yonil commented Jan 8, 2024

@bblommers fixed the test. Should be good now.

Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one - thanks for the fix @yonil!

@bblommers bblommers merged commit 78b4437 into spulec:master Jan 14, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants