Issue 68, 67: add additional exception handling to patching code

[mbox]

Adds more exception handling while patching modules to handle various issues that can arise. I think this will fix #68, #67

[mbox]

One question/issue - this uses a minimal approach to exception handling, but arguably it should do pokemon catching since if anything goes wrong while patching/unpatching it's probably better to keep going rather than bomb out and leave things in an odd state

[spulec]

I was actually just working on a work project that uses freezegun as a dependency and ran into this. Within a minute of hitting the bug, I checked my email and saw this PR. Sometimes open source is really great.

Thanks for your help!

[spulec]

Just saw your question: I think all of those ifs should really be elifs so I don't think it matters. Is that right?

[mbox]

I'm more thinking that the code should be:

try:
   if attribute_value == real_datetime:
               setattr(module, module_attribute, FakeDatetime)
   if attribute_value == real_date:
                setattr(module, module_attribute, FakeDate)
   if attribute_value == real_time:
                setattr(module, module_attribute, fake_time)
except:
   pass

rather than being explicit about which exceptions to catch. But agree that it should be if/elif not if/if

[mbox]

PS thanks for a nifty tool!

[spulec]

Oh, I see.

I'm always a bit nervous to have blanket excepts like that. I think I would rather wait and see if people run into other issues before making the change.

(going to fix the if/elif in master shortly)

Thanks again!

[spulec]

As soon as I tried the new version with my work project I ran into a RuntimeError so it appears that your suggestion is necessary. Added with 47d113e.

Going to do some more testing, but I will release a new version shortly.

[mbox]

Yes, just ran into exactly same issue on my project!

On Monday, 29 December 2014, Steve Pulec notifications@github.com wrote:

As soon as I tried the new version with my work project I ran into a
RuntimeError so it appears that your suggestion is necessary. Added with
47d113e
47d113e
.

Going to do some more testing, but I will release a new version shortly.

—
Reply to this email directly or view it on GitHub
#70 (comment).

Sent from my phone, please excuse any mistakes.