Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various changes to organizations endpoint #3175

Merged
merged 3 commits into from
Jul 27, 2020
Merged

Various changes to organizations endpoint #3175

merged 3 commits into from
Jul 27, 2020

Conversation

hacosta
Copy link
Contributor

@hacosta hacosta commented Jul 24, 2020

No description provided.

@hacosta hacosta changed the title Org changes Various changes to organizations endpoint Jul 24, 2020
@coveralls
Copy link

coveralls commented Jul 24, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.0006%) to 94.321% when pulling 091052b on hacosta:org-changes into c166d97 on spulec:master.

bblommers
bblommers requested changes Jul 25, 2020
View reviewed changes
Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hacosta, thanks for your PR!
Can you add some unit tests for these changes, both positive and negative (to verify the errors are indeed raised when appropriate)?

moto/organizations/responses.py Outdated Show resolved Hide resolved
@hacosta
Copy link
Contributor Author

hacosta commented Jul 26, 2020

Thanks for the feedback and sorry about the noise. LMK if this works.

bblommers
bblommers approved these changes Jul 27, 2020
View reviewed changes
Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks again @hacosta!

@bblommers bblommers merged commit cdc4385 into getmoto:master Jul 27, 2020
@bblommers
Copy link
Collaborator

This is now part of moto >= 1.3.15.dev999

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bblommers bblommers bblommers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hacosta @coveralls @bblommers