PR: Add additional cases for code cells and block comments

[andfoy]

Fixes #8
Fixes #9

[andfoy]

@jnsebgosselin @eafpres @ccordoba12, could you please check if this PR address the missing code cells/block comments syntax?

[jnsebgosselin]

So based on what was said in PR spyder-ide/spyder#13885, if I want to test that, I need to clone the repo locally, fetch the branch and install the repo with pip install -e . ?

Is there any risk that I'm going to break my conda installation by doing that? If I recall, Carlos always said that mixing pip and conda is something that is very bad to do.

[andfoy]

@jnsebgosselin, since this package does not depend on Spyder, it shouldn't break anything, so you can install it with pip without any problems, just make sure that is installed with pip install -e . --no-deps

[jnsebgosselin]

@jnsebgosselin, since this package does not depend on Spyder, it shouldn't break anything, so you can install it with pip without any problems, just make sure that is installed with pip install -e . --no-deps

Ok excellent. The --no-deps part is good. I'm going to try it out later today.

[eafpres]

@jnsebgosselin @eafpres @ccordoba12, could you please check if this PR address the missing code cells/block comments syntax?

Honestly I'm not sure I'm competent to test this without breaking something locally, so please do not wait on me.

[andfoy]

@eafpres Don't worry, just a quick question should # ### (note the space before the 3 #'s) be a block comment as well?

[eafpres]

question should # ### (note the space before the 3 #'s) be a block comment as well?

I can understand that with the # %% case but this makes less sense to me. However, I’d rather defer to the dev team on that.

[ccordoba12]

This looks pretty good, thanks @andfoy!

[andfoy]

@ccordoba12, all the review comments should be fixed now

[ccordoba12]

Last comment for you @andfoy, then this should be ready.

[ccordoba12]

Thanks @andfoy!

[MCilento93]

@ccordoba12, all the review comments should be fixed now

Hello
Which release has the issue of review comments fixed?

[andfoy]

Hi @MCilento93, this fix is available in pyls-spyder v0.2.1, released yesterday

[MCilento93]

Mmm I have spyder 4.2.0 o 4.1.5

Can I install or do I need to wait for next spyder release?

Sincerely

[andfoy]

You can install it by using conda or pip:

# Anaconda (Recommended)
conda install pyls-spyder=0.2.1 -c spyder-ide

# Pip
pip install -U pyls-spyder

[MCilento93]

You can install it by using conda or pip:

# Anaconda (Recommended)
conda install pyls-spyder=0.2.1 -c spyder-ide

# Pip
pip install -U pyls-spyder

installed, but unfortunately I do not see the comments row (like ### , !!! and so forth)