Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Add support for textDocument/foldingRange call for code cells #15

Merged
merged 5 commits into from
Dec 11, 2020
Merged

PR: Add support for textDocument/foldingRange call for code cells #15

merged 5 commits into from
Dec 11, 2020

Conversation

andfoy
Copy link
Member

@andfoy andfoy commented Dec 10, 2020

@andfoy andfoy self-assigned this Dec 10, 2020
@andfoy andfoy added this to the v0.3.0 milestone Dec 10, 2020
@andfoy andfoy mentioned this pull request Dec 10, 2020
Merged
ccordoba12
ccordoba12 reviewed Dec 11, 2020
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good, thanks @andfoy! One question though: should we add a minimal requirement for our dependency in python-language-server?

I mean, I could release 0.36.2 with your fixes for this, so we can depend on it. What do you think?

@andfoy andfoy merged commit feb3669 into spyder-ide:master Dec 11, 2020
@andfoy andfoy deleted the cell_folding branch December 11, 2020 21:01
@remisalmon remisalmon mentioned this pull request Feb 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 left review comments

Assignees

@andfoy andfoy

Labels
None yet
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.

Code folding cells
2 participants
@andfoy @ccordoba12