Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Update FontAwesome to 5.4.2 #102

Merged
merged 1 commit into from
Nov 2, 2018

Conversation

darkvertex
Copy link
Contributor

Hey, it's me again. Putting this on the latest FA5 version. 🎩

FYI the "regular" style did not add any new icons since the last update, but they did modify the fontfile so I put it as part of these changes. That's why there is nothing new in the "regular" charmap. (I believe they adjusted the look of an icon or two.)

This updates brings 52 new icons:
https://fontawesome.com/icons?d=gallery&s=brands&v=5.4.0,5.4.1,5.4.2&m=free
https://fontawesome.com/icons?d=gallery&s=solid&v=5.4.0,5.4.1,5.4.2&m=free

@@ -271,7 +278,6 @@
"reddit": "f1a1",
"reddit-alien": "f281",
"reddit-square": "f1a2",
"rendact": "f3e4",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI this one didn't disappear, just got renamed to wpressr.

@ccordoba12 ccordoba12 added this to the v0.5.3 milestone Nov 2, 2018
@ccordoba12 ccordoba12 changed the title Update FontAwesome to 5.4.2 PR: Update FontAwesome to 5.4.2 Nov 2, 2018
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @darkvertex!

@ccordoba12 ccordoba12 merged commit a21fcd4 into spyder-ide:master Nov 2, 2018
@darkvertex darkvertex deleted the fa_5.4.2_update branch November 2, 2018 16:26
@darkvertex
Copy link
Contributor Author

Hi @ccordoba12 did you release this in PyPI yet?

@darkvertex
Copy link
Contributor Author

As I answer my own question, it seems you released it in PyPI but not this repo:
This is out: https://pypi.org/project/QtAwesome/0.5.3/
but in here there is no 0.5.3 as of writing this: https://github.com/spyder-ide/qtawesome/releases

That's why I got confused. You may wanna get those in sync.

@ccordoba12
Copy link
Member

Sorry, I forgot to push the 0.5.3 tag, I just did it right now.

@darkvertex
Copy link
Contributor Author

All good. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants