Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Update to FA 5.6.3 and new "update_fa5" setup.py subcommand #104

Merged
merged 10 commits into from
Jan 3, 2019

Conversation

darkvertex
Copy link
Contributor

Hey hey, it's me again! πŸ‘‹

This upgrades to FontAwesome 5.5.0 but this is an extra special update... ✨

As I'm kind of repeating the same actions over and over when I contribute new FA updates, I explored the idea of creating a setup.py subcommand to do the hard work for me.

Now we can just run:

> python setup.py update_fa5 --fa-version 5.5.0
running update_fa5
Downloading from URL: https://github.com/FortAwesome/Font-Awesome/releases/download/5.5.0/fontawesome-free-5.5.0-web.zip
Dumping updated "brands" charmap: /home/alan/dev/qtawesome/qtawesome/fonts/fontawesome5-brands-webfont-charmap.json
Dumping updated "brands" font: /home/alan/dev/qtawesome/qtawesome/fonts/fontawesome5-brands-webfont.ttf
Dumping updated "solid" charmap: /home/alan/dev/qtawesome/qtawesome/fonts/fontawesome5-solid-webfont-charmap.json
Dumping updated "solid" font: /home/alan/dev/qtawesome/qtawesome/fonts/fontawesome5-solid-webfont.ttf
Dumping updated "regular" charmap: /home/alan/dev/qtawesome/qtawesome/fonts/fontawesome5-regular-webfont-charmap.json
Dumping updated "regular" font: /home/alan/dev/qtawesome/qtawesome/fonts/fontawesome5-regular-webfont.ttf
Patching new MD5 hashes in: /home/alan/dev/qtawesome/qtawesome/iconic_font.py
New "brands" hash is: b69de69a4ff8ca0abe96ec0b0c180c5b
New "solid" hash is: 48f54f63d7711d0912a9a10205538fc4
New "regular" hash is: b48c48ea8457846a5695b139c377d3d1
Dumping updated file: /home/alan/dev/qtawesome/qtawesome/iconic_font.py

Finished!
Please check the git diff to make sure everything went okay.
You should also edit README.md and qtawesome/docs/source/usage.rst to reflect the changes.

Handy! 🎩

@darkvertex
Copy link
Contributor Author

Looks like my use of urllib2 in setup.py made it unfriendly to Python 3. I'll look into that.

@darkvertex
Copy link
Contributor Author

All good now. πŸ˜…

@ccordoba12 ccordoba12 added this to the v0.5.4 milestone Dec 10, 2018
@ccordoba12 ccordoba12 changed the title FA 5.5.0 update + new "update_fa5" setup.py subcommand PR: Update FA 5.5.0 + new "update_fa5" setup.py subcommand Dec 10, 2018
setup.py Outdated Show resolved Hide resolved
@darkvertex darkvertex changed the title PR: Update FA 5.5.0 + new "update_fa5" setup.py subcommand PR: Update to FA 5.6.3 + new "update_fa5" setup.py subcommand Jan 2, 2019
@darkvertex
Copy link
Contributor Author

I moved the code to a separate file as per your request and reused my new subcommand to update to FA 5.6.3 which is the latest as of writing this comment.

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your work on this! Merging and releasing 0.5.4 right away.

@ccordoba12 ccordoba12 changed the title PR: Update to FA 5.6.3 + new "update_fa5" setup.py subcommand PR: Update to FA 5.6.3 and new "update_fa5" setup.py subcommand Jan 3, 2019
@ccordoba12 ccordoba12 merged commit d2cbc1d into spyder-ide:master Jan 3, 2019
@ccordoba12
Copy link
Member

0.5.4 is out!

@darkvertex
Copy link
Contributor Author

Awesome! Thanks for releasing promptly. πŸ‘

@darkvertex darkvertex deleted the fa5_updater_command branch January 3, 2019 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants