Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Add IconWidget to display icon as widget #127

Merged
merged 21 commits into from
Feb 12, 2020
Merged

PR: Add IconWidget to display icon as widget #127

merged 21 commits into from
Feb 12, 2020

Conversation

doudz
Copy link
Contributor

@doudz doudz commented Oct 24, 2019 •
edited
Loading

Add IconWidget object to display any icon as a widget

# Spining icon as a widget
spin_widget = qta.IconWidget()
spin_icon = qta.icon('mdi.loading', color='red',
                     animation=qta.Spin(spin_widget))
spin_widget.setIcon(spin_icon)

# simple widget
simple_widget = qta.IconWidget('mdi.web', color='blue')

qtawesome-screenshot

@doudz
Add IconWidget
a14c0c4 
Display icon as widget
@doudz doudz changed the title Iconwidget IconWidget Oct 24, 2019
@doudz doudz changed the title IconWidget PR: Add IconWidget to display icon as widget Oct 24, 2019
@ccordoba12 ccordoba12 added this to the v0.6.1 milestone Nov 6, 2019
@ccordoba12
Copy link
Member

ccordoba12 commented Nov 6, 2019 •
edited
Loading

@goanpeca, what do you think about this one?

@doudz
Copy link
Contributor Author

doudz commented Nov 7, 2019

I improved it a little

@goanpeca
Copy link
Member

goanpeca commented Nov 7, 2019

Sure, it can be useful on some cases.

Thanks for working on this 👍🏼

ccordoba12
ccordoba12 reviewed Nov 7, 2019
View reviewed changes
qtawesome/__init__.py Outdated Show resolved Hide resolved
goanpeca
goanpeca reviewed Nov 7, 2019
View reviewed changes
qtawesome/__init__.py Outdated Show resolved Hide resolved
goanpeca
goanpeca reviewed Nov 7, 2019
View reviewed changes
README.md Outdated Show resolved Hide resolved
goanpeca
goanpeca reviewed Nov 7, 2019
View reviewed changes
README.md Outdated Show resolved Hide resolved
doudz and others added 3 commits November 8, 2019 18:33
@doudz @goanpeca
Update qtawesome/__init__.py
9d39a31 
Co-Authored-By: Gonzalo Peña-Castellanos <goanpeca@gmail.com>
@doudz @goanpeca
Update qtawesome/__init__.py
f76bada 
Co-Authored-By: Gonzalo Peña-Castellanos <goanpeca@gmail.com>
@doudz @goanpeca
Update README.md
b8e3fe4 
Co-Authored-By: Gonzalo Peña-Castellanos <goanpeca@gmail.com>
@ccordoba12 ccordoba12 removed this from the v0.6.1 milestone Jan 8, 2020
@doudz
Copy link
Contributor Author

doudz commented Jan 10, 2020

Sorry for delay
I think it's ready now

@ccordoba12 ccordoba12 added this to the v0.7.0 milestone Jan 18, 2020
@ccordoba12
Copy link
Member

@goanpeca, please give a new review to this one and approve if it's ready.

@goanpeca
Copy link
Member

goanpeca commented Feb 5, 2020

Please merge with master so new CI can run. Thanks! I will review after that :-)

@goanpeca
Copy link
Member

@doudz could you merge with master and solve the conflicts?

@ccordoba12
Copy link
Member

@doudz, please merge with master to fix the new merge conflict.

@ccordoba12
Copy link
Member

@goanpeca, is this ready?

goanpeca
goanpeca previously approved these changes Feb 11, 2020
View reviewed changes
Copy link
Member

@goanpeca goanpeca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @doudz !

Yep @ccordoba12 ready!

ccordoba12
ccordoba12 reviewed Feb 11, 2020
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@doudz, I left a minor comment for you.

qtawesome/__init__.py Outdated Show resolved Hide resolved
@ccordoba12 ccordoba12 dismissed goanpeca’s stale review February 11, 2020 23:39

Change quotes in docstring is required.

@goanpeca goanpeca merged commit e7e6afe into spyder-ide:master Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 left review comments

@goanpeca goanpeca goanpeca left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@doudz @ccordoba12 @goanpeca