-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Rename FontAwesome5 fonts #98
PR: Rename FontAwesome5 fonts #98
Conversation
Looks good, thanks @darkvertex! |
Fantastic! Hopefully this helps others like me who might've been scratching their heads wondering why most |
So, is this PR working for you @flutefreak7? Just checking before merging and releasing 0.5.1 |
Thanks for taking time to work on this issue @darkvertex Tried to change to : And now it works. Can you try it @flutefreak7. Commands are : |
I figured out why the other name didn't work... it was too long! The max length family name QFont appears to handle for me is 31, which is apparently a well-documented Windows limit. When I make the Solid name When set the Solid font name to This discussion shows that due to limitations on both Mac and Windows, it's wise to stay below 30. |
Ok then, I shortened their names like @flutefreak7 suggested. Good now? |
It's working for me :) |
β¦r" and "FontAwesome 5 Free Solid". (Fixes spyder-ide#97.)
0d225e7
to
2cf81a9
Compare
Great to hear! π That completes the 2 confirmations I wanted. @ccordoba12: I just squashed my commits and re-pushed, just keeping the last good commit. -- You can merge and release this as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @darkvertex for your help with this!
0.5.1 is out! |
(:hand: Please don't merge until the reporters of issue #97 confirm it fixes their issues. β)[Edited 30/09/2018: Fix confirmed by @flutefreak7 and @jules-ch -- good to go! πβοΈ]
I used fontname.py to run:
then updated the md5 hashes in
iconic_font.py
so QtAwesome doesn't freak out.In theory this should fix a bug with QFont merging Regular and Solid for formerly sharing the same font family of "FontAwesome 5 Free".
Fixes #97