Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Rename FontAwesome5 fonts #98

Conversation

darkvertex
Copy link
Contributor

@darkvertex darkvertex commented Sep 28, 2018

(:hand: Please don't merge until the reporters of issue #97 confirm it fixes their issues. βœ‹)
[Edited 30/09/2018: Fix confirmed by @flutefreak7 and @jules-ch -- good to go! πŸ‘βœ”οΈ]

I used fontname.py to run:

python fontname.py "FontAwesome 5 Free Regular" ./qtawesome/qtawesome/fonts/fontawesome5-regular-webfont.ttf
python fontname.py "FontAwesome 5 Free Solid" ./qtawesome/qtawesome/fonts/fontawesome5-solid-webfont.ttf

then updated the md5 hashes in iconic_font.py so QtAwesome doesn't freak out.

In theory this should fix a bug with QFont merging Regular and Solid for formerly sharing the same font family of "FontAwesome 5 Free".


Fixes #97

@ccordoba12 ccordoba12 added this to the v0.5.1 milestone Sep 28, 2018
@ccordoba12
Copy link
Member

Looks good, thanks @darkvertex!

@flutefreak7
Copy link

Fantastic! Hopefully this helps others like me who might've been scratching their heads wondering why most fa5s icons weren't working. I know making platform-specific fixes is tiresome, so I applaud you guys taking the time to put this in. Thank you.

@ccordoba12 ccordoba12 changed the title Rename FontAwesome5 fonts to fix Windows bug #97 PR: Rename FontAwesome5 fonts to fix Windows bug #97 Sep 28, 2018
@ccordoba12
Copy link
Member

So, is this PR working for you @flutefreak7? Just checking before merging and releasing 0.5.1

@ccordoba12 ccordoba12 changed the title PR: Rename FontAwesome5 fonts to fix Windows bug #97 PR: Rename FontAwesome5 fonts Sep 28, 2018
@jules-ch
Copy link

Thanks for taking time to work on this issue @darkvertex
I couldn't make it work with your changes, don't know if the name has something to do with this.

Tried to change to :
Font Awesome 5 Free Regular
Font Awesome 5 Free Solid
respectively.

And now it works. Can you try it @flutefreak7.

Commands are :
python fontname.py "Font Awesome 5 Free Regular" qtawesome/fonts/fontawesome5-regular-webfont.ttf
python fontname.py "Font Awesome 5 Free Solid" qtawesome/fonts/fontawesome5-solid-webfont.ttf

@flutefreak7
Copy link

I figured out why the other name didn't work... it was too long! The max length family name QFont appears to handle for me is 31, which is apparently a well-documented Windows limit.

When I make the Solid name 'a'*31 I get this:
image

When set the Solid font name to 'a'*32 I get this:
image

This discussion shows that due to limitations on both Mac and Windows, it's wise to stay below 30.

@darkvertex
Copy link
Contributor Author

Ok then, I shortened their names like @flutefreak7 suggested. Good now?

@jules-ch
Copy link

It's working for me :)

@darkvertex darkvertex force-pushed the rename_fontawesome5_families_for_windows_bug branch from 0d225e7 to 2cf81a9 Compare September 30, 2018 16:52
@darkvertex
Copy link
Contributor Author

Great to hear! πŸ˜„ That completes the 2 confirmations I wanted.

@ccordoba12: I just squashed my commits and re-pushed, just keeping the last good commit. -- You can merge and release this as v0.5.1 in my opinion.

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @darkvertex for your help with this!

@ccordoba12 ccordoba12 merged commit 9477c2e into spyder-ide:master Sep 30, 2018
@ccordoba12
Copy link
Member

0.5.1 is out!

@darkvertex darkvertex deleted the rename_fontawesome5_families_for_windows_bug branch September 30, 2018 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

minus-circle not working
4 participants