Patch QComboBox with PySide?

[astrofrog]

In qt-helpers, we patch QComboBox because on PySide, storing Python objects in the userData causes segmentation faults (while it works correctly in PyQt4 and PyQt5). Here is our implementation (which is only used with PySide):

https://github.com/glue-viz/qt-helpers/blob/master/qt_helpers.py#L320

Would you be interested in something similar here? If so, I can open a PR.

[ccordoba12]

We were not aware of that issue, but if you recognized it as such in Glue then I think it's important to have it in qtpy too.

So, yes, please open a PR for it :-)

[Nodd]

Just to be sure, did you check that the bug still exists in the last version ?
If that's the case a PR is welcomed !

[astrofrog]

Ok, I'll work on it at the weekend! (and I'll check the bug is still present)

[goanpeca]

Hi @astrofrog just checking if you found the issue :-p

[astrofrog]

@goanpeca - oops, haven't had time yet, will try and look shortly.

[astrofrog]

I'm finally working on switching glue to use QtPy, and will report back on this soon.

[ccordoba12]

Nice!! Please send us as many PR as you consider necessary to support
Gue :-)

El 08/06/16 a las 06:13, Thomas Robitaille escribió:

I'm finally working on switching glue to use QtPy, and will report
back on this soon.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#21 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAWS7YXHzT6cgexuOlYhT4oIpPit3cx8ks5qJqPngaJpZM4H7QBT.