-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Fix and improve Coveralls reporting #268
Conversation
4eada47
to
7c68c83
Compare
Sidenote: With |
7c68c83
to
4819140
Compare
be5ddac
to
18e6f43
Compare
090134d
to
5e6e223
Compare
5e6e223
to
15ba5d5
Compare
492252d
to
8dfcf38
Compare
b795856
to
48ee5d5
Compare
48ee5d5
to
741967a
Compare
@dalthviz As usual, I spent way more time on this than I should have, but this brings our reported coverage from the pre- #262 25% to now 75%, a full 3x improvement, with more detailed, representative and easy to read data. We might want to consider adding coveralls to our formal CI checks, like Spyder has, to check for significant regressions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @CAM-Gerlach ! LGTM 👍
Thanks @dalthviz |
Coveralls is now showing 0 coverage after PR #262 . This PR will fix it, as well as implement some other low-hanging fruit fixes and improvements on top of that.
As it turns out, it was indeed due to the test working dir not matching the one coveralls was running in, due to the hacky workaround to fix the issues from QtPy having a non-
src
dir layout.Not only does this fix the issue with coveralls, but it also makes the paths much cleaner, reports coverage from all jobs and with descriptive job names, and combines coverage across all bindings (since naturally a lot of code is specific to one binding), along with fixing/cleaning up a few other things. This makes our total coverage much higher and more representative, bringing it from 25% to 75%, a 3x improvement, as well as makes the coveralls output easier to read and more informative.
Fix #267