-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Update gitignore, gitattributes, license, authors and security policy #278
Conversation
93fbdf2
to
c40b9ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @CAM-Gerlach ! I left some comments/questions (mostly on the .gitattributes
and .gitignore
file). Otherwise LGTM 👍
c40b9ad
to
11b09d2
Compare
Just to clarify again, the @dalthviz To address all the "is this necessary" questions, the primarily goal of this PR was to standardize on comprehensive, proven |
Thanks for the explanation @CAM-Gerlach ! Thinking about is still quite strange to me to have stuff related to things that probably will not be used here (maybe is just for me though). What do you think @ccordoba12 ? |
Perhaps, but so long as they're suitably comprehensive, standardized and well-proven, they shouldn't need to ever be looked at again (aside the very occasional update, that with standardized files, can be simple drag and drop). After all, it hasn't been a problem for you before on any of the other Spyder repos using these same standardized files for the past three years, has it? ^_^ Something I've discovered time and again along my own journey as a scientist and a programming is that just going with one standard, consistent approach that works in all probable cases is usually a lot more efficient then spending the time and mental energy thinking about which method I can get away with in each particular case, and the risk of making a mistake if I'm wrong. In this case, this is doubly true since there is no objective cost to just use the standardized, proven version and modest objective benefits, and no clear benefit to spending the considerable time, energy and risk now and in the future determining line by line and section by section whether each may be relevant. |
Any feedback on this @ccordoba12 ? |
11b09d2
to
876c074
Compare
Just to TL;DR my take @ccordoba12 , these are the standard versions we have in many/most of our other modern repos (with a few improvements making sure the |
Although I find the changes in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @CAM-Gerlach!
Adds/updates various meta-files and syncs with with other Spyder projects; final bit of general maintenance for v2.0.0.
Namely: