PR: Import Callable and MutableMapping in py3compat for Python 2 compat #285
Conversation
The PY2 code path was not importing Callable, which breaks the compat module when it tries to import Callable from py3compat. Signed-off-by: David Aguilar <davvid@gmail.com>
|
Thanks again for qtpy! I patched this in our vendored copy. Heads-up @comand -- thanks for the report. |
There was a problem hiding this comment.
LGTM, thanks @davvid — just in time to get this in for what will probably be the final QtPy 1.x release (1.11.3).
|
@davvid Just to make sure you're briefed on our plans, 1.11.3 is planned to be the last 1.x release before QtPy 2.0 comes out in the next few weeks (certainly before the end of the year), which adds support for PySide6 and PyQt6, and drops it for the long-EoL PyQt4/Pyside1 and Python 2. Of course, since you have it vendored, you can keep patching it if needed, but we'd love for you to try out QtPy 2.0 (at least after #271 is merged) and let us know if you run into any issues we can fix, Thanks! |
CAM-Gerlach
changed the title
Hey @davvid, nice to see you around. And thanks a lot for |
The PY2 code path was not importing Callable, which breaks the
compat module when it tries to import Callable from py3compat.
Signed-off-by: David Aguilar davvid@gmail.com