Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Set CI job's timeout to 10 min to force a stalled test to terminate #309

Merged
merged 1 commit into from
Dec 24, 2021

Conversation

kumattau
Copy link
Contributor

@kumattau kumattau changed the title Set CI job's timeout to 10 min to force a stalled test to terminate PR: Set CI job's timeout to 10 min to force a stalled test to terminate Dec 24, 2021
@dalthviz dalthviz added this to the v2.1.0 milestone Dec 24, 2021
@dalthviz dalthviz merged commit 82f20a8 into spyder-ide:master Dec 24, 2021
@kumattau kumattau deleted the ci-timeout branch December 24, 2021 17:03
@kumattau
Copy link
Contributor Author

@dalthviz

I am testing now, but each time of Test (PyQt5, PyQt6, PySide2 and PySide6) on a environment may be forced to 10 min.
I will check and fix that total time of all Tests a environment is forced to 10 min.

@kumattau
Copy link
Contributor Author

@dalthviz,

I am testing now, but each time of Test (PyQt5, PyQt6, PySide2 and PySide6) on a environment may be forced to 10 min.
I will check and fix that total time of all Tests a environment is forced to 10 min.

I checked again, 10 min timeout worked as expected.
It seems to take 15 minutes for the job to finish due to the cancellation process of the github runner.

Here are the test results.
Could you please check if everything is OK?

https://github.com/spyder-ide/qtpy/actions/runs/1619770750

If everything is OK, I will create tests and submit jobs at the weekend.

@kumattau
Copy link
Contributor Author

kumattau commented Dec 24, 2021

@dalthviz

On yesterday, the 3 tests for working commits was running on six hours.
I'm very sorry about that.
Screenshot from 2021-12-25 03-03-56

@dalthviz
Copy link
Member

I checked again, 10 min timeout worked as expected.
It seems to take 15 minutes for the job to finish due to the cancellation process of the github runner.

Here are the test results.
Could you please check if everything is OK?

https://github.com/spyder-ide/qtpy/actions/runs/1619770750

Looks good to me and will close #310 then 👍

On yesterday, the 3 tests for working commits was running on six hours.
I'm very sorry about that.

No worries

If everything is OK, I will create tests and submit jobs at the weekend.

Just in case, I will be taking some time off so I will check again things next year (most probably starting the second week of January) so no need to hurry :)

Anyhow thank you so much for all the work that you have been doing here and in qtawesome and happy holidays! 🎄

@dalthviz dalthviz modified the milestones: v2.1.0, v2.0.1 Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants