PR: Add mapping for missing enum values aliases on QtCore.Qt
#314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalthviz
changed the title
QtCore.QtQtCore.Qt
CAM-Gerlach
reviewed
Jan 14, 2022
CAM-Gerlach
previously approved these changes
Jan 18, 2022
There was a problem hiding this comment.
Looks good from my end, at least, though there could be some more advanced Qt issues I'm missing.
EDIT: And the failing tests...investigation in progress.
EDIT 2: Oops, its just the coverage issue you fixed before in #313 that we literally just talked about...my memory is not so good, lol.
Improve comments and import order Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
dalthviz
force-pushed
the
fixes_issue_306
branch
from
88b7f9c
to
734951d
Compare
dalthviz
changed the title
QtCore.QtQtCore.Qt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #306
Note: Needs a rebase after #313 is merged