Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Remove QHeaderView patch related files #334

Merged
merged 1 commit into from
Apr 15, 2022
Merged

PR: Remove QHeaderView patch related files #334

merged 1 commit into from
Apr 15, 2022

Conversation

dalthviz
Copy link
Member

@dalthviz dalthviz commented Apr 8, 2022

Fixes #332

@dalthviz dalthviz added this to the v2.1.0 milestone Apr 8, 2022
@dalthviz dalthviz self-assigned this Apr 8, 2022
ccordoba12
ccordoba12 approved these changes Apr 8, 2022
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @dalthviz!

@dalthviz
Copy link
Member Author

Do you have any comment @CAM-Gerlach ?

CAM-Gerlach
CAM-Gerlach approved these changes Apr 15, 2022
View reviewed changes
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry for the delay @dalthviz —I was taking a short break from GitHub for a few days to focus on other things, and then got overwhelmed when I came back

@CAM-Gerlach CAM-Gerlach merged commit b1d4a65 into spyder-ide:master Apr 15, 2022
@CAM-Gerlach
Copy link
Member

Looks like the tests started segfaulting on PyQt6 + Windows on both Py3.7 and 3.10 (no conda). Based on the check logs, it seems likely this is due to the PyQt PyPI wheels for Qt 6.3.0 being released; any idea on fixing this from our end, or should we pin to qt 6.2.x for now?

@dalthviz
Copy link
Member Author

any idea on fixing this from our end, or should we pin to qt 6.2.x for now?

Maybe it make sense to open a new issue for that and check if we can fix it for 2.1.0 (hopefully preventing the segfault even when using Qt 6.3.0 instead of just constraining to install Qt 6.2.x) Will open a new issue with your comment and start checking if I can do something about it 👍

@dalthviz dalthviz mentioned this pull request Apr 18, 2022
Closed
@CAM-Gerlach
Copy link
Member

Thanks @dalthviz !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

@CAM-Gerlach CAM-Gerlach CAM-Gerlach approved these changes

Assignees

@dalthviz dalthviz

Labels
type:Task
Projects
None yet
Milestone
v2.1.0
Development

Successfully merging this pull request may close these issues.

Remove QHeaderView patch
3 participants
@dalthviz @CAM-Gerlach @ccordoba12