PR: Add command line support for Mypy #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Going to need #335 for tests to pass here, BTW |
CAM-Gerlach
force-pushed
the
add-mypy-cli-v2
branch
from
f751e23
to
83f3cb6
Compare
dalthviz
reviewed
Apr 20, 2022
There was a problem hiding this comment.
Thanks @CAM-Gerlach ! Left some comments regarding the description in the README for the command and a missing header for a file otherwise this LGTM 👍
ccordoba12
reviewed
Apr 21, 2022
There was a problem hiding this comment.
Thanks @CAM-Gerlach for your help with this! I left some minor comments, otherwise looks good to me.
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
ccordoba12
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a CLI to inject the appropriate arguments into a user's Mypy invocation to ensure proper type checking. Also provides an easy way to check the currently selected Qt binding and QtPy's version.
This is based on #217 , rebased and updated for QtPy 2.x, with a number of other improvements, fixes and refinements.
Fixes #216
Closes #217