Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Remove patch that may be limited to PySide-5.11a1 only #407

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

StSav012
Copy link
Contributor

The removal looks safe, provided the oldest supported PySide2 is 5.12.

See #405

@StSav012 StSav012 marked this pull request as ready for review February 11, 2023 12:01
@CAM-Gerlach CAM-Gerlach linked an issue Feb 14, 2023 that may be closed by this pull request
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @StSav012

@CAM-Gerlach CAM-Gerlach changed the title Remove patch that “may be limited to PySide-5.11a1 only” PR: Remove patch that may be limited to PySide-5.11a1 only Feb 14, 2023
@dalthviz dalthviz added this to the v2.3.1 milestone Feb 14, 2023
Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @StSav012 !

@dalthviz dalthviz merged commit 6f7e1e7 into spyder-ide:master Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove patch that "may be limited to PySide-5.11a1 only"
3 participants