PR: Skip QtPositioning tests on Conda Qt >=6.4.3 where its not included #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 18, 2023
dalthviz
approved these changes
Mar 20, 2023
There was a problem hiding this comment.
Thanks @CAM-Gerlach ! LGTM 👍
As a side note, regarding the QT_VERSION parsing that sounds like a good idea 👍 Although I'm not sure if that should be done for at least a minor release 🤔 , maybe creating an issue to track the idea would be good (so we can get more feedback first).
Thanks; opened as #415 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discovered in PR #413 , as of the release of
qt-main6.4.3 on Conda-Forge (conda-forge/qt-main-feedstock#135), the Qt6 Conda jobs are failing because QtPositioning is no longer included inqt-mainas of 6.4.3, along with the other QSensors stuff for device sensors.Therefore, I just went ahead and skipped the test on
QT6andconda. It might be nice to be able to actually check the version, though for that we really should do a proper version comparison on theQT_VERSION(for which it would be a good idea to parse it and the other versions in__init__to "version_info"-style version tuples, e.g. underQT_VERSION_INFOand similar, which might be more generally useful to users and ourselves. However, since that would be a slightly less trivial change, I deferred that until getting your feedback on it.