New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Symmetrize path
and location
of QLibraryInfo
#420
PR: Symmetrize path
and location
of QLibraryInfo
#420
Conversation
The related SO topic doesn't seem to help. |
path
and location
of QLibraryInfo
path
and location
of QLibraryInfo
NB @dalthviz , this job seems to fail every other run, with re-running fixing it. Maybe some kind of caching issue? I looked into it previously but wasn't totally sure what was going on. |
Not sure either 🤔 maybe opening an issue to track that some flakiness there exists is worthy? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @StSav012 ! LGTM 👍
What do you think @CAM-Gerlach @ccordoba12 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd defer to your expertise here @dalthviz and @ccordoba12 , but LGTM from my side for what its worth.
Yeah, I can do that next time I see it fail. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks @StSav012!
More and more code is initially written for Qt6 and then required to run on Qt5. There are many things introduced or renamed in Qt6. One of them is
QLibraryInfo.location
→QLibraryInfo.path
andQLibraryInfo.LibraryLocation
→QLibraryInfo.LibraryPath
.Following #393, I'd like to port
QLibraryInfo.path
andQLibraryInfo.LibraryPath
back to Qt5. This way, all the supported flavors haveQLibraryInfo.location
,QLibraryInfo.path
,QLibraryInfo.LibraryLocation
, andQLibraryInfo.LibraryPath
altogether.