Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Symmetrize path and location of QLibraryInfo #420

Conversation

StSav012
Copy link
Contributor

@StSav012 StSav012 commented Apr 3, 2023

More and more code is initially written for Qt6 and then required to run on Qt5. There are many things introduced or renamed in Qt6. One of them is QLibraryInfo.locationQLibraryInfo.path and QLibraryInfo.LibraryLocationQLibraryInfo.LibraryPath.

Following #393, I'd like to port QLibraryInfo.path and QLibraryInfo.LibraryPath back to Qt5. This way, all the supported flavors have QLibraryInfo.location, QLibraryInfo.path, QLibraryInfo.LibraryLocation, and QLibraryInfo.LibraryPath altogether.

@StSav012
Copy link
Contributor Author

StSav012 commented Apr 3, 2023

ERROR module 'importlib_metadata' has no attribute 'distributions' when creating a venv. Please restart the job.

The related SO topic doesn't seem to help.

@StSav012 StSav012 marked this pull request as ready for review April 3, 2023 16:50
@dalthviz dalthviz added this to the v2.4.0 milestone Apr 3, 2023
@dalthviz dalthviz changed the title Symmetrize path and location of QLibraryInfo PR: Symmetrize path and location of QLibraryInfo Apr 3, 2023
@CAM-Gerlach
Copy link
Member

NB @dalthviz , this job seems to fail every other run, with re-running fixing it. Maybe some kind of caching issue? I looked into it previously but wasn't totally sure what was going on.

@dalthviz
Copy link
Member

dalthviz commented Apr 4, 2023

this job seems to fail every other run, with re-running fixing it. Maybe some kind of caching issue? I looked into it previously but wasn't totally sure what was going on.

Not sure either 🤔 maybe opening an issue to track that some flakiness there exists is worthy?

Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @StSav012 ! LGTM 👍

What do you think @CAM-Gerlach @ccordoba12 ?

Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd defer to your expertise here @dalthviz and @ccordoba12 , but LGTM from my side for what its worth.

@CAM-Gerlach
Copy link
Member

Not sure either thinking maybe opening an issue to track that some flakiness there exists is worthy?

Yeah, I can do that next time I see it fail.

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @StSav012!

@ccordoba12 ccordoba12 merged commit f1d56a3 into spyder-ide:master Apr 4, 2023
12 checks passed
@StSav012 StSav012 deleted the symmetrize_QLibraryInfo_path_and_location branch April 5, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants