New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for QtMultimedia #50
Conversation
Hi @davvid, thanks for the PR I just made some changes, could you rebase or merge with latests master? |
Thanks, just rebased. |
@davvid the tests folder is now inside the qtpy module, can you check this is the case? |
Oops, fixed it to go into the qtpy/tests/ folder. Thanks! |
Awesome, thanks :-) The failing tests on appveyor are my fault. fixing now, will ping you for a rebase :-| |
Hey @davvid, I fixed the CI, could you please rebase once more? @ccordoba12 I did some clean up of the codebase:
|
8fffb97
to
98dfb07
Compare
Thanks @goanpeca I've rebased and all are passing except QuantifiedCode which seems to be tripping up over the |
Yes, it looks good, just waiting for @ccordoba12 to double check. For now the |
@goanpeca, another thing: could we remove the QuantifiedCode integration until you remove our star imports? |
I added a protected branch and required checks before merging. Quantified code is an optional check now. So tests will appear as passing (no need to disable it) |
@davvid could you rebase again :-) ? |
Thanks @goanpeca! |
Rebased. Thanks y'all, sounds great. |
@davvid, I just released 1.1.2 and now it seems this needs another rebase :-) |
@ccordoba12 I had not yet made the fix PR to remove the problem that would otherwise break navigator. Did you fix it? otherwise if that new release makes it the repo.continuum.io is going to break navigator. |
Sorry, I thought you had done it already :-/ We discussed about it several days, and since this is a very simple fix, I assumed it was done :-) |
Well you just broke navigator... |
Thanks @ccordoba12 just rebased onto the latest origin/master and re-pushed. |
Add a wrapper around QtMultimedia to provide access to QAudio, QSound and friends. Closes spyder-ide#49 Signed-off-by: David Aguilar <davvid@gmail.com>
Sweet, just rebased for the fix. Thanks @ccordoba12 |
Thanks, merging (at last :-) |
Add a wrapper around QtMultimedia to provide access to QAudio, QSound
and friends.
Closes #49
Signed-off-by: David Aguilar davvid@gmail.com