New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce renamed methods of QHeaderView in PyQt4 and PySide #65
Merged
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
3dc26fb
fixes #64 introduce renamed methods of QHeaderView in PyQt4 and PySide
tobiasgehring 7a6c8c0
added a test for qheaderview implementation
tobiasgehring e863f42
fixed qheaderview patch test for pyside
tobiasgehring 722e745
raise exception if old methods are called
tobiasgehring 2c506d6
Merge remote-tracking branch 'upstream/master' into qheaderview
tobiasgehring File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
def introduce_renamed_methods_qheaderview(QHeaderView): | ||
|
||
def sectionsClickable(self): | ||
""" | ||
QHeaderView.sectionsClickable() -> bool | ||
""" | ||
return QHeaderView.isClickable(self) | ||
QHeaderView.sectionsClickable = sectionsClickable | ||
|
||
def sectionsMovable(self): | ||
""" | ||
QHeaderView.sectionsMovable() -> bool | ||
""" | ||
return QHeaderView.isMovable(self) | ||
QHeaderView.sectionsMovable = sectionsMovable | ||
|
||
def sectionResizeMode(self, logicalIndex): | ||
""" | ||
QHeaderView.sectionResizeMode(int) -> QHeaderView.ResizeMode | ||
""" | ||
return QHeaderView.resizeMode(self, logicalIndex) | ||
QHeaderView.sectionResizeMode = sectionResizeMode | ||
|
||
def setSectionsClickable(self, clickable): | ||
""" | ||
QHeaderView.setSectionsClickable(bool) | ||
""" | ||
return QHeaderView.setClickable(self, clickable) | ||
QHeaderView.setSectionsClickable = setSectionsClickable | ||
|
||
def setSectionsMovable(self, movable): | ||
""" | ||
QHeaderView.setSectionsMovable(bool) | ||
""" | ||
return QHeaderView.setMovable(self, movable) | ||
QHeaderView.setSectionsMovable = setSectionsMovable | ||
|
||
def setSectionResizeMode(self, *args): | ||
""" | ||
QHeaderView.setSectionResizeMode(QHeaderView.ResizeMode) | ||
QHeaderView.setSectionResizeMode(int, QHeaderView.ResizeMode) | ||
""" | ||
QHeaderView.setResizeMode(self, *args) | ||
QHeaderView.setSectionResizeMode = setSectionResizeMode | ||
|
||
|
||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why define a new method each time ? This code should be equivalent:
I think there a re some differences, like the
__name__
attribute would still be the one from the initial method. On the other hand the help should be more complete (instead of just the signature in the current state of this PR).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Nodd the signatures of pyqt are no better than what Tobias did