-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Add support for compiling directories of QtSass #23
Conversation
- Added complex example including imports from subdirectories - Simplified watchdog event handler - Now we just recompile anytime the source directory changes - This is far more reliable and accounts for imports - Aligned api compile* names with libsass
Codecov Report
@@ Coverage Diff @@
## master #23 +/- ##
===========================================
+ Coverage 32.79% 84.95% +52.15%
===========================================
Files 8 8
Lines 186 206 +20
===========================================
+ Hits 61 175 +114
+ Misses 125 31 -94
Continue to review full report at Codecov.
|
I understand the feeling but I would prefer to have separate methods for this and not a universal method that does all. or having separate argument? |
Yeah, I'm not very fond of universal methods or flag arguments that modify the behavior of a function drastically. I created issue #24 to track this discussion. I think any change in that regards to the api behavior should occur in a separate pull request. |
bf5ac78
to
5f37a68
Compare
Added some cli tests including compiling and watching both examples/dummy.scss and examples/complex. |
Hi @danbradham this is looking great :-), vert thorough. You happy with the current state, or is there something else you want to work on? |
Thanks, yeah it's looking good to me. |
fixes #18
I think the compile methods should be aligned closer to libsass in that sass.compile handles strings, files, and directories and delegates to sass.compile_filename and sass.compile_dirname. This pull request lays the foundation to achieve that by renaming compile_and_save to compile_filename and adding the compile_dirname method.