Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Prepare release #32

Merged
merged 2 commits into from
Apr 26, 2019
Merged

PR: Prepare release #32

merged 2 commits into from
Apr 26, 2019

Conversation

goanpeca
Copy link
Member

@goanpeca goanpeca commented Apr 24, 2019

Fixes #5
Fixes #7
Fixes #17

@codecov-io
Copy link

codecov-io commented Apr 24, 2019

Codecov Report

Merging #32 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #32   +/-   ##
=======================================
  Coverage   92.79%   92.79%           
=======================================
  Files           8        8           
  Lines         236      236           
=======================================
  Hits          219      219           
  Misses         17       17
Impacted Files Coverage Δ
qtsass/__init__.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77b25a5...9d9c869. Read the comment docs.

@goanpeca
Copy link
Member Author

@danbradham making the release as we will need this for ColinDuquesnoy/QDarkStyleSheet#138

@ccordoba12 ccordoba12 added this to the v0.1.0 milestone Apr 24, 2019
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@goanpeca, looks good! I just left some minor comments.

RELEASE.md Outdated Show resolved Hide resolved
RELEASE.md Outdated Show resolved Hide resolved
RELEASE.md Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
@goanpeca
Copy link
Member Author

Fixed @ccordoba12

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @goanpeca!

@ccordoba12 ccordoba12 merged commit 1fda568 into spyder-ide:master Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create PyPI package Create RELEASE.md instructions Create a changelog
4 participants