Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR:馃殗 Add deployment pipeline step #65

Merged
merged 2 commits into from
Sep 12, 2022

Conversation

s-weigand
Copy link
Contributor

@dalthviz Thanks for the new release 馃帀

Hope this makes releasing new versions easier in the future

@dalthviz dalthviz added this to the v0.4.0 milestone Sep 5, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2022

Codecov Report

Merging #65 (f86f462) into master (e8e15e7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #65   +/-   ##
=======================================
  Coverage   87.52%   87.52%           
=======================================
  Files          12       12           
  Lines         513      513           
=======================================
  Hits          449      449           
  Misses         64       64           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dalthviz dalthviz changed the title 馃殗 Add deployment pipeline step PR:馃殗 Add deployment pipeline step Sep 5, 2022
Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @s-weigand thank you for the help checking ways to automate a little bit the release process!

Checking the workflow changes I guess this depends on a pypi_password (PyPI token) being defined in the repository secrets, right?

Also, I think we need to update https://github.com/spyder-ide/qtsass/blob/master/RELEASE.md to follow up the changes proposed here (at least removing the duplicated steps that now should be done with Github Actions and adding a note about what happens when the git push --tags is done, i.e it is the trigger for this new deploy job).

Also, do you think it could be worthy to add some validation step to the generated distributions, like the check you can do with twine check dist/*?

Edit: Thinking a little bit more, should we instead of using the tag as trigger for this new step use the release event (so creating a GitHub release)? What do you think?

@s-weigand
Copy link
Contributor Author

@dalthviz Yes you need to create a token at PyPI (best would be with project scope) and set the pypi_password secret of the repository to this value.

I updated the release instructions in f86f462 to match the new workflow.

The twine check dist/* is run by default in pypa/gh-action-pypi-publish so I don't think we need to duplicate it.

If you create a release you have to either use an existing tag or create a new one so the tag event will be triggered in any case.

Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @s-weigand !

@dalthviz dalthviz merged commit c657390 into spyder-ide:master Sep 12, 2022
@dalthviz dalthviz modified the milestones: v0.4.0, v0.3.2 Sep 12, 2022
@s-weigand s-weigand deleted the add-CI-deploy-step branch September 12, 2022 18:46
@dalthviz dalthviz mentioned this pull request Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants