Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add a setting to disable printing the stack on every Pdb command #153

Merged
merged 4 commits into from
Oct 16, 2019

Conversation

impact27
Copy link
Contributor

Add an option to disable code echo

@impact27 impact27 changed the title PR: Disable echo [Depends on #151] PR: Disable echo Oct 5, 2019
@impact27 impact27 changed the title [Depends on #151] PR: Disable echo PR: Disable echo Oct 14, 2019
@@ -418,7 +418,8 @@ def interaction(self, frame, traceback):
self.setup(frame, traceback)
if self.send_initial_notification:
self.notify_spyder(frame)
self.print_stack_entry(self.stack[self.curindex])
if get_ipython().kernel._pdb_print_code:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add _pdb_print_code to pdb settings

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We decided that this was not necessary because Pdb settings are used to initialize the Pdb instance, but this value can change on every evaluation.

@ccordoba12 ccordoba12 added this to the v1.6.0 milestone Oct 16, 2019
@ccordoba12 ccordoba12 changed the title PR: Disable echo PR: Add a setting to disable printing the stack on every Pdb command Oct 16, 2019
@ccordoba12 ccordoba12 merged commit 6148dc4 into spyder-ide:master Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants