Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Fix missing stderr when the kernel crashes #334

Merged
merged 1 commit into from
Nov 10, 2021

Conversation

impact27
Copy link
Contributor

stderr can be replaced before a crash, resulting in the error never being sent to the frontend. This explicitly writes the error to __stderr__. Worst case the error will be written twice.

@ccordoba12 ccordoba12 changed the title Fix stderr missing PR: Fix missing stderr when the kernel crashes Nov 10, 2021
@ccordoba12 ccordoba12 changed the base branch from master to 2.x November 10, 2021 20:30
@ccordoba12 ccordoba12 added this to the v2.2.0 milestone Nov 10, 2021
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @impact27!

@ccordoba12 ccordoba12 merged commit 41387d8 into spyder-ide:2.x Nov 10, 2021
ccordoba12 added a commit that referenced this pull request Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants