Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Add feature to prepend/append PYTHONPATH to sys.path #478

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

PR: Add feature to prepend/append PYTHONPATH to sys.path #478

wants to merge 10 commits into from

Commits on Jun 19, 2024

  1. Add prioritize argument to determine whether to place PYTHONPATHs ahe… 

    …ad of or behind sys.path
    @mrclary
    mrclary committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    1c84305 View commit details
    Browse the repository at this point in the history

  2. set_spyder_pythonpath is obsolete as SpyderKernel.update_syspath will… 

    … be invoked by Spyder after startup.
    @mrclary
    mrclary committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    3ba1adc View commit details
    Browse the repository at this point in the history

  3. Receive list of strings instead of dictionary for paths

    @mrclary
    mrclary committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    da25347 View commit details
    Browse the repository at this point in the history

  4. Add unit test for priortizing PYTHONPATH in sys.path

    @mrclary
    mrclary committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    b05079f View commit details
    Browse the repository at this point in the history

  5. PEP8

    @mrclary
    mrclary committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    c4fc05f View commit details
    Browse the repository at this point in the history

  6. Store original sys.path so that user paths do not need to be removed … 

    …upon update. This obviates the need for sending the old user paths with the sig_pythonpath_updated signal.

What happened to the '' (current working directory) entry in sys.path?
    @mrclary
    mrclary committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    8dcf279 View commit details
    Browse the repository at this point in the history

  7. Ensure that the current working directory is re-added to sys.path aft… 

    …er the kernels starts. This is removed prior to kernel startup to protect spyder-kernels from offending user modules, but should be put back after startup.
    @mrclary
    mrclary committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    e0a1985 View commit details
    Browse the repository at this point in the history

  8. Clean up current working directory manipulations

    @mrclary
    mrclary committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    a31ef4a View commit details
    Browse the repository at this point in the history

  9. Apply review suggestion 

    Co-authored-by: Jitse Niesen <jitseniesen@yahoo.com>
    @mrclary @jitseniesen
    mrclary and jitseniesen committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    a6d1bb3 View commit details
    Browse the repository at this point in the history

  10. Apply suggestions from code review 

    Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
    @mrclary @ccordoba12
    mrclary and ccordoba12 committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    1285e11 View commit details
    Browse the repository at this point in the history