This repository has been archived by the owner on May 7, 2023. It is now read-only.
Make test more robust #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ption The previous test failed on some 32-bits computers, even with 5% margin.
|
@ghisvail Can you check whether with this PR the test passes on your 32-bits machines, or would you prefer me to first do a release including this PR? |
|
@jitseniesen Just make the release and I'll let the Debian builders do the testing. |
|
@ghisvail This fix is in version 0.1.1, now available on PyPI and here on GitHub. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make test more robust by only checking sign of measured memory consumption. The previous test failed on some 32-bits computers, even with 5% margin; see comments at 4da36a2.