PR: QWebChannel implementation and tests #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccordoba12
reviewed
Jul 31, 2017
| @@ -21,6 +22,29 @@ | |||
| from spyder.utils.qthelpers import create_action, add_actions | |||
|
|
|||
| from qtpy.QtWebEngineWidgets import WEBENGINE | |||
| if WEBENGINE: | |||
| from PyQt5.QtWebChannel import QWebChannel | |||
There was a problem hiding this comment.
Could we add support for QtWebChannel in qtpy? I think it's better because PySide2 also supports Qt5.
There was a problem hiding this comment.
I was thinking exactly the same! I can send a PR
ccordoba12
reviewed
Jul 31, 2017
| @@ -28,7 +28,7 @@ dependencies: | |||
| export PATH="$HOME/miniconda/bin:$PATH" && | |||
| source activate test && | |||
| conda install -q ciocheck -c spyder-ide --no-update-deps && | |||
| if [ "$CIRCLE_NODE_INDEX" = "2" ]; then pip install -q spyder pyqt5 tornado pexpect; else conda install -q -y spyder && conda install tornado pexpect; fi && | |||
| if [ "$CIRCLE_NODE_INDEX" = "2" ]; then pip install -q spyder pyqt5==5.8.0 tornado pexpect; else conda install -q -y spyder && conda install tornado pexpect; fi && | |||
There was a problem hiding this comment.
Why do we need to pin pyqt5 to 5.8.0
There was a problem hiding this comment.
I tried with 5.9.0, but it segfaults
|
I'm in PyQt-5.9.0 / Windows , so I should not upgrade for now ? |
|
The problem was only related to our tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #102