PR: Redirecting server stderr and stdout to files #62
Conversation
|
@ccordoba12 Is this correct? |
|
I'll let you know tomorrow. I'm very tired now ;-) |
| stdout=subprocess.PIPE, | ||
| stderr=subprocess.PIPE) | ||
| stdout=self.server_stdout, | ||
| stderr=self.server_stderr) |
There was a problem hiding this comment.
Let's make the server write to a file only if DEV is True. DEV can be imported from config.base and it's True when you start Spyder with bootstrap.py.
|
Looks good. Please add a test for this by setting By the way, could we use a single file for both outputs? |
|
Yes, it is possible to redirect both outputs to a single file |
|
Ok, but can we prefix it with something like |
|
If it's too much trouble, then we should leave things as they are, though ;-) |
|
I think it could be possible if we implement a file wrapper around a single file, but in terms of concurrency, I don't know what would be the expected behaviour |
|
Then please leave two files. In any case, this feature is just for debugging purposes. So just add a test for this and we're ready! |
spyder_terminal/__init__.py
Outdated
| @@ -12,5 +12,5 @@ | |||
| if PYQT5: | |||
| from .terminalplugin import TerminalPlugin as PLUGIN_CLASS | |||
|
|
|||
| VERSION_INFO = (0, 1, 1) | |||
| VERSION_INFO = (0, 1, 2) | |||
There was a problem hiding this comment.
The dev version should include a dev0, like this
https://github.com/spyder-ide/spyder/blob/master/spyder/__init__.py#L30
Fixes #60