PR: Launch first console instance only if server is up #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccordoba12
reviewed
Jun 23, 2017
spyder_terminal/terminalplugin.py
Outdated
| QTimer.singleShot(250, self.__wait_server_to_start) | ||
| elif code == 200: | ||
| self.create_new_term(give_focus=False) | ||
| self.sig_server_is_up.emit() |
There was a problem hiding this comment.
This signal seems unnecessary, I mean, nothing is connected to it.
ccordoba12
reviewed
Jun 23, 2017
spyder_terminal/terminalplugin.py
Outdated
| try: | ||
| code = requests.get('http://127.0.0.1:{0}'.format( | ||
| self.port)).status_code | ||
| except Exception: |
There was a problem hiding this comment.
Remove Exception here because it's not needed.
There was a problem hiding this comment.
It is needed, when the server is unavailable it actually launches an Exception
There was a problem hiding this comment.
requests.exceptions.ConnectionError: HTTPConnectionPool(host='127.0.0.1', port=8000):
Max retries exceeded with url: /
(Caused by NewConnectionError('<requests.packages.urllib3.connection.HTTPConnection object at 0x7fd0b06a3390>:
Failed to establish a new connection: [Errno 111] Connection refused',))
There was a problem hiding this comment.
Yeah, but if you only use
try:
...
except:
...then all exceptions will be captured.
|
Looks good now, thanks @andfoy! |
ccordoba12
reviewed
Jun 27, 2017
| @@ -82,8 +85,9 @@ def test_new_terminal(qtbot): | |||
| """Test if a new terminal is added.""" | |||
| # Setup widget | |||
| terminal = setup_terminal(qtbot) | |||
| term = terminal.get_current_term() | |||
| # terminal.close_term() | |||
ccordoba12
reviewed
Jun 27, 2017
| @@ -70,6 +72,7 @@ def test_terminal_font(qtbot): | |||
| def test_terminal_tab_title(qtbot): | |||
| """Test if terminal tab titles are numbered sequentially.""" | |||
| terminal = setup_terminal(qtbot) | |||
| # terminal.close_term() | |||
ccordoba12
reviewed
Jun 27, 2017
| @@ -56,8 +56,10 @@ def setup_terminal(qtbot): | |||
| def test_terminal_font(qtbot): | |||
| """Test if terminal loads a custom font.""" | |||
| terminal = setup_terminal(qtbot) | |||
| term = terminal.get_current_term() | |||
| # terminal.close_term() | |||
ccordoba12
reviewed
Jun 27, 2017
spyder_terminal/terminalplugin.py
Outdated
| ' please restart Spyder on debugging mode ' | ||
| "and open an issue with the contents of " | ||
| "<tt>{1}</tt> and <tt>{2}</tt> " | ||
| "files.".format(self.port, |
There was a problem hiding this comment.
Let's improve this a bit
files at {3}.
where {3} is
https://github.com/spyder-ide/spyder-terminal/issues
|
I left a couple of comments, then I think this one is ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59